fix: introduce approx size to patterns and use in ScatterBrush #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Mar 17, 2024
dordsor21
commented
- fixes LocalVectorSet can only contain vectors within 1024 blocks (cuboid) of the first entry error. #2610
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
bot
added
unresolved-merge-conflict
and removed
unresolved-merge-conflict
labels
# Conflicts: # worldedit-core/src/main/java/com/fastasyncworldedit/core/function/pattern/OffsetPattern.java # worldedit-core/src/main/java/com/fastasyncworldedit/core/function/pattern/RandomOffsetPattern.java # worldedit-core/src/main/java/com/fastasyncworldedit/core/function/pattern/SurfaceRandomOffsetPattern.java
dordsor21
force-pushed
the
fix/pattern-size-for-scatter
branch
from
612b399
to
b04bfdb
Compare
SirYwell
requested changes
Mar 28, 2024
worldedit-core/src/main/java/com/fastasyncworldedit/core/command/tool/brush/ScatterBrush.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/math/BlockVectorSet.java
Show resolved
Hide resolved
SirYwell
approved these changes
Mar 28, 2024
NotMyFault
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.