Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heightmap brush with imgur images #2680

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix heightmap brush with imgur images #2680

merged 1 commit into from
Apr 12, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

The previous PR did not fix imgur heightmaps due to different methods being called.

Description

Moved the fix in another method, so it can be called from multiple places as needed. I hope I've catched all open resources and closed accordingly.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options
Loading

@PierreSchwang PierreSchwang requested a review from a team as a code owner April 9, 2024 21:24
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 9, 2024
@NotMyFault NotMyFault merged commit a0ef151 into main Apr 12, 2024
9 checks passed
@NotMyFault NotMyFault deleted the fix/imgurHeightmap branch April 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants