Add a BiomeCategories API (#2338) #2777
Conversation
* Add a BiomeCategories API * licenses * Use a supplier to retain the lazy-load & dynamicness of the existing system, but still retaining the inversion of control that this PR was intended to provide
There was a problem hiding this comment.
I see that the temporary regen world was renamed back to worldeditregentempworld - I guess that's intentional? (helps with merge conflicts as well i guess). I have no issue with that whatsoever to be fair.
Is the commented merge conflict in 1.20R1 PaperweightAdapter (L880+) required in the future or is there any specific reason to keep it in?
Looks good otherwise? Might be worth merging before starting work on 1.21
Ah, no the rename probably shouldn't happen, and the merge conflict was probably missed because it was commented I guess 🙃 |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
# Conflicts: # worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R1/PaperweightWorldNativeAccess.java # worldedit-bukkit/adapters/adapter-1_20_2/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext/fawe/v1_20_R2/PaperweightWorldNativeAccess.java # worldedit-bukkit/adapters/adapter-1_20_4/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext.fawe/v1_20_R3/PaperweightWorldNativeAccess.java # worldedit-bukkit/adapters/adapter-1_20_5/src/main/java/com/sk89q/worldedit/bukkit/adapter/ext.fawe/v1_20_R4/PaperweightWorldNativeAccess.java # worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicReader.java
Add a BiomeCategories API
licenses
Use a supplier to retain the lazy-load & dynamicness of the existing system, but still retaining the inversion of control that this PR was intended to provide