Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home command reset #4295

Merged

Conversation

OneLiteFeather
Copy link
Member

Overview

This PR should fix the missing reset happening while /p sethome none was executed. I had help with @TheMeinerLP which found the underlying solution together with me, as I am not a great developer with basic sql knowledge yet.

Fixes #4294

Description

  • We fixed the setposition method with the default value and added a comment too to give other developers a hint to look it up on the statement. Also we added a location not null check because the issue lies within the equals implementation.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options
Loading

OneLiteFeather added 2 commits January 17, 2024 19:43
The issue lies within the equals implementation
@OneLiteFeather OneLiteFeather requested a review from a team as a code owner January 17, 2024 18:58
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 17, 2024
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one comment, which is not a dealbreaker but not really required.

No idea who introduced the default value as "DEFAULT" instead of just making the column nullable?

@PierreSchwang PierreSchwang requested a review from a team January 19, 2024 20:37
@NotMyFault NotMyFault merged commit a1d94af into IntellectualSites:main Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/plot sethome none doesnt reset to default location
3 participants