Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove entitys with CUSTOM spawn-reason on CreatureSpawnEvent. #4297

Merged

Conversation

nicolube
Copy link
Contributor

@nicolube nicolube commented Jan 18, 2024

Overview

Use "CUSTOM" spawn reason in all entity listeners.

It was already in EntityEventListener:173 and PaperListener:206 but not used in CreatureSpawnEvent with prevented custom marked entity such as "LingeriePotion" spawned and handled by a separate Plugin

Description

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options
Loading

@nicolube nicolube requested a review from a team as a code owner January 18, 2024 21:44
@github-actions github-actions bot added the Feature This PR proposes a new feature label Jan 18, 2024
@nicolube
Copy link
Contributor Author

Sry, think I named my branch wrong, this is a BugFix

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've changed the labels accordingly :)

@NotMyFault NotMyFault added Bugfix This PR fixes a bug and removed Feature This PR proposes a new feature labels Jan 21, 2024
@NotMyFault NotMyFault merged commit fccc146 into IntellectualSites:main Jan 21, 2024
7 checks passed
@NotMyFault
Copy link
Member

Caused #4305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants