New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MUSIC soundcategory for plot music flag #4302

Merged

NotMyFault merged 1 commit into main from fix/plotMusic

Jan 21, 2024

Member

PierreSchwang commented Jan 20, 2024

Overview

Fixes #4301

Submitter Checklist

Beta Give feedback

Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry.

Ensure that the pull request title represents the desired changelog entry.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public fields and methods are annotated with `@since TODO`.

New public fields and methods are annotated with @since TODO.
Options
Successfully updated the issue's project

There was an error updating the issue's project
I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

I read and followed the contribution guidelines.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options


          chore/fix: use MUSIC sound category for plot music

f94f7ac

PierreSchwang requested a review from a team as a code owner

January 20, 2024 21:43

github-actions bot added the Bugfix label

NotMyFault approved these changes

View reviewed changes

Member

NotMyFault left a comment

Thanks!

NotMyFault merged commit 9566af5 into main

8 checks passed

NotMyFault deleted the fix/plotMusic branch

January 21, 2024 11:38

PierreSchwang mentioned this pull request

fix plot music volume to span full plot #4391

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment