Bug squashing #14
Merged
Bug squashing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not perfect maybe with every feature but I think the basic functionality is there
Keboo
approved these changes
Oct 18, 2022
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
BenjaminMichaelis
force-pushed
the
BugSquashing
branch
from
5c1ed88
to
598965a
Compare
BenjaminMichaelis
force-pushed
the
BugSquashing
branch
from
598965a
to
2d66f20
Compare
|
Ignoring tests that I broke in the process of fixing the mainly used method, so need to go back later and clean up the tests and other options, but want to get a working version to nuget for mark to use in the meantime. |
Keboo
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try to fix the bugs in this. Specifically the updating of listings and tests to be correct.