Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance testing of the GOV rule #4255

Closed
lehins opened this issue Apr 10, 2024 · 0 comments · Fixed by #4268
Closed

Conformance testing of the GOV rule #4255

lehins opened this issue Apr 10, 2024 · 0 comments · Fixed by #4268
Assignees
@Soupstraw
Labels
conway
Projects
Conway

Comments

@lehins
Copy link
Contributor

lehins commented Apr 10, 2024

Currently testing of GOV rule is disabled in the conformance testing, which needs to be fixed. Quote from #4212 (comment)

GOV rule should have all the necessary constraints, but when I ran it, I got some mismatches between the spec and the implementation. I think some of it might be because I haven't properly updated all of the types after updating. The next PR will be about getting the GOV rule to pass.
@lehins lehins added the conway label Apr 10, 2024
@lehins lehins added this to To do in Conway via automation Apr 10, 2024
@lehins lehins moved this from To do to In review in Conway Apr 29, 2024
@Soupstraw Soupstraw mentioned this issue May 2, 2024
Merged
9 tasks
Conway automation moved this from In review to Done May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soupstraw Soupstraw

Labels
conway
Projects
Conway
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable conformance tests for GOV rule IntersectMBO/cardano-ledger
2 participants
@lehins @Soupstraw