Enable conformance tests for GOV rule #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/gov-conformance
branch
13 times, most recently
from
88c763a
to
7603e9b
Compare
Soupstraw
force-pushed
the
jj/gov-conformance
branch
10 times, most recently
from
718d3bd
to
2bc270f
Compare
Soupstraw
requested review from
lehins,
aniketd,
teodanciu and
MaximilianAlgehed
Soupstraw
force-pushed
the
jj/gov-conformance
branch
from
2bc270f
to
06b1a15
Compare
teodanciu
reviewed
Apr 29, 2024
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/gov-conformance
branch
10 times, most recently
from
f01dcd2
to
669866d
Compare
teodanciu
reviewed
May 1, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/gov-conformance
branch
from
669866d
to
51acd44
Compare
MaximilianAlgehed
approved these changes
May 2, 2024
lehins
approved these changes
May 2, 2024
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/Orphans.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/gov-conformance
branch
4 times, most recently
from
d27d25c
to
06e5e61
Compare
teodanciu
reviewed
May 3, 2024
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/gov-conformance
branch
5 times, most recently
from
a470b7f
to
30cceaa
Compare
Fixed a bug in prevGovActionId translation Fixed TestRep of Proposals Added generation timeout tests Bump cardano-ledger-executable-spec Fixed `OMap.assocList` Added Testable instance for `ImpTestM` Co-authored-by: Maximilian Algehed <MaximilianAlgehed@users.noreply.github.com> Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Soupstraw
force-pushed
the
jj/gov-conformance
branch
from
30cceaa
to
639c79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds conformance testing for the
GOVrule.resolves #4255
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)