Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and reorganize conformance tests #4212

Merged
merged 9 commits into from
Apr 10, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Mar 22, 2024

Description

This PR does some reorganizing of the V2 constrained generators and conformance tests.

  • Conway era V2 specs are moved from cardano-ledger-test to cardano-ledger-conway:testlib
  • Made a ExecutableSpecRule typeclass interface to have a common interface for running conformance tests for each rule

This only touches the infrastructure for running conformance tests with V2 constrained generators. The tests themselves will be added in a follow-up PR.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw changed the title Update and refactor conformance tests Update and reorganize conformance tests Mar 22, 2024
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 14 times, most recently from 6f4b629 to dfcb4ee Compare March 28, 2024 15:56
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 11 times, most recently from b4c1448 to 98fe217 Compare April 2, 2024 14:24
@Soupstraw Soupstraw marked this pull request as ready for review April 2, 2024 14:24
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 2 times, most recently from 92c3f82 to 4f2bef4 Compare April 2, 2024 14:39
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 8 times, most recently from 5bfebd6 to 6ea72ce Compare April 9, 2024 15:51
@lehins lehins force-pushed the jj/conformance-bump branch from 6ea72ce to 3223cc9 Compare April 9, 2024 19:42
@lehins
Copy link
Collaborator

lehins commented Apr 9, 2024

There is a missing TypeOperators build failure for newer GHCs. Other than that the PR is ready to be merged

@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch 2 times, most recently from 598cb84 to ff7b91d Compare April 10, 2024 11:46
@Soupstraw Soupstraw force-pushed the jj/conformance-bump branch from ff7b91d to a62f0c3 Compare April 10, 2024 12:55
@Soupstraw Soupstraw enabled auto-merge (squash) April 10, 2024 13:38
@Soupstraw Soupstraw disabled auto-merge April 10, 2024 13:38
@Soupstraw Soupstraw enabled auto-merge (squash) April 10, 2024 13:39
@Soupstraw Soupstraw merged commit 72f2f17 into master Apr 10, 2024
15 checks passed
@Soupstraw Soupstraw deleted the jj/conformance-bump branch April 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants