Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup. Remove some deprecated type synonyms. #3205

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Cleanup. Remove some deprecated type synonyms. #3205

merged 3 commits into from
Dec 12, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Dec 10, 2022 •
edited
Loading

Description

This is just a cleanup PR. It takes care of a few things:

  • Remove deprecated type synonyms (node has already accounted for those): ValidatedTx, TxOut, TxBody, TxSeq, Script, Value, PParamDelta.
  • as Core qualified import is not needed in most places due to removal of above deprcations
  • Stop importing Crypto qualified as CC. It no longer conflicts with recently renamed EraCrypto
  • Rename Cardano.Ledger.Shelley.Metadata module to Cardano.Ledger.Shelley.TxAuxData

There aren't really any semantic changes here. Just the cleanup

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with ormolu (which can be run with scripts/ormolise.sh
  • Self-reviewed the diff

Soupstraw
Soupstraw approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks

eras/shelley/impl/src/Cardano/Ledger/Shelley/Tx.hs Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/UTxO.hs Outdated Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/UTxO.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the lehins/cleanup-deprecations branch 2 times, most recently from d82b39b to e06928e Compare December 12, 2022 14:55
@Soupstraw
Copy link
Contributor

Soupstraw commented Dec 12, 2022 •
edited
Loading

sorry for the force pushes, I accidentally pushed some changes onto your branch and then undid them :s

@lehins
Copy link
Collaborator Author

lehins commented Dec 12, 2022

sorry for the force pushes, I accidentally pushed some changes onto your branch and then undid them :s

No worries.

JaredCorduan
JaredCorduan approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic! 🙌

@lehins lehins merged commit fd62695 into master Dec 12, 2022
@iohk-bors iohk-bors bot deleted the lehins/cleanup-deprecations branch December 12, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@Soupstraw Soupstraw Soupstraw approved these changes

@aniketd aniketd Awaiting requested review from aniketd

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @Soupstraw @JaredCorduan