Add a Preds to generate valid GovActionStates. #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-constraints-forGovState
branch
from
ae4689b
to
a854534
Compare
teodanciu
reviewed
Dec 5, 2023
TimSheard
force-pushed
the
ts-constraints-forGovState
branch
from
a854534
to
6fc45e3
Compare
Soupstraw
reviewed
Dec 6, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/LedgerState.hs
Outdated
Show resolved
Hide resolved
lehins
approved these changes
Dec 7, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Ast.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Examples.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/Certs.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/LedgerState.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Vars.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-constraints-forGovState
branch
from
7292824
to
7ec411b
Compare
Introduced Partial RootTargets, can be used to generate Sum types. Changed the rewriter of Oneof to use (GenFrom frequency) Added to Vars variabes for the fields of GovActionState and GovAction Added RootTarget for GovActionState, and (Partial) RootTarget for GovAction.
lehins
force-pushed
the
ts-constraints-forGovState
branch
from
0da3a15
to
6af808a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GovActionStates have a tree structure which is hard to generate correctly
Added a some features to make this possible.
Introduced Partial RootTargets, can be used to generate Sum types.
Changed the rewriter of Oneof to use (GenFrom frequency).
Added to Vars variables for the fields of GovActionState and GovAction.
Added RootTarget for GovActionState, and (Partial) RootTarget for GovAction.
Description
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)