Improve cbor serialization of TxWits in Conway #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
changed the title
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
5 times, most recently
from
625d7c5
to
55bad91
Compare
teodanciu
commented
Dec 21, 2023
lehins
reviewed
Dec 22, 2023
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Binary/TxWitsSpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
3 times, most recently
from
256f761
to
bde3102
Compare
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
from
bde3102
to
3a6261c
Compare
teodanciu
changed the title
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
3 times, most recently
from
09171cd
to
cbc5ca5
Compare
teodanciu
commented
Jan 3, 2024
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
9 times, most recently
from
0b4e6b4
to
f4e8667
Compare
lehins
approved these changes
Jan 4, 2024
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/witness-cbor-improvements
branch
from
f4e8667
to
5b4b1b3
Compare
- unnecessarily converting to/from plain decoder - wrong default in function expecting failure
in roundtrip tests
lehins
force-pushed
the
td/witness-cbor-improvements
branch
from
5b4b1b3
to
455eef6
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves part of: #3922
transaction_witness_set:Note: still remaining: checking for duplicates in Annotator fields, not possible at the moment with the current Annotator mechanism
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)