Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPO voting thresholds for security relevant parameters #3982

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 10, 2024

Description

This PR adds a way to mark protocol parameter fields as SecurityRelevant. The security relevant fields require sufficient votes from SPOs, where the required votes are determined by the pvtSecurityRelevant parameter.

resolves #3925

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/spo-group branch 4 times, most recently from 04ab57b to 7b19b47 Compare January 11, 2024 15:14
@Soupstraw Soupstraw marked this pull request as ready for review January 11, 2024 15:14
@Soupstraw Soupstraw requested review from lehins, aniketd and teodanciu and removed request for lehins January 11, 2024 15:15
@Soupstraw Soupstraw force-pushed the jj/spo-group branch 2 times, most recently from d8682d3 to d39ba1c Compare January 12, 2024 14:16
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks great. I am not too fond of some naming choices, but that should be easy to fix.

eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
eras/conway/impl/test/data/conway-genesis.json Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Tools.hs Outdated Show resolved Hide resolved
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've discussed this with @WhatisRT and current behavior implemented in this PR is indeed the desired behavior.

Great work!

@Soupstraw Soupstraw merged commit 101fcf2 into master Jan 18, 2024
11 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StakePool PParams security group
3 participants