Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EnactState from ConwayGovState #4013

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 25, 2024

Description

This PR removes the EnactState field from ConwayGovState. The fields that have to be stored in the state are copied over to the ConwayGovState.

Since we're not storing the whole enact state in the ledger state any more, we don't have to check the invariants in the EPOCH rule.

resolves #3998

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/unstore-enact-state branch 15 times, most recently from 88bcebc to 5080ce1 Compare January 26, 2024 15:10
@Soupstraw Soupstraw marked this pull request as ready for review January 26, 2024 16:41
@Soupstraw Soupstraw force-pushed the jj/unstore-enact-state branch 3 times, most recently from b8047b7 to 3538170 Compare January 29, 2024 10:35
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Exactly what we needed

Thank you.

eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Epoch.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand! 🙌

@Soupstraw Soupstraw enabled auto-merge (rebase) January 30, 2024 10:49
@Soupstraw Soupstraw merged commit 70b9691 into master Jan 30, 2024
11 of 22 checks passed
@Soupstraw Soupstraw deleted the jj/unstore-enact-state branch January 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop storing EnactState in the ledger state
3 participants