-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MinFeeRefScriptCoinsPerByte. #4055
Conversation
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
51c622b
to
1e110df
Compare
1e110df
to
7b49e17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small issue in the unit test. Which works right now, but if we ever turned it into a property with some randomness in it, the test would break.
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxoSpec.hs
Outdated
Show resolved
Hide resolved
7b49e17
to
7ef9b49
Compare
* Rename it to MinFeeRefScriptCostPerByte. * Update its type from Coin to NonNegativeInterval.
7ef9b49
to
9ba9316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, there is some conflict right now. Other than that it is ready to go
Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era
* New Conway.cddl updates (cml-chain/cml-chain-wasm) Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era * conway multi-era update + various fixes * resolve merge conflict * use conway costmodels for all eras (babbage costmdls found in alonzo on sancho testnet) * IntoIter for NonemptySet<T>
Description
Fixes #4052
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)