Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MinFeeRefScriptCoinsPerByte. #4055

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 6, 2024

  • Rename it to MinFeeRefScriptCostPerByte.
  • Update its type from Coin to NonNegativeInterval.

Description

Fixes #4052

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/minfeerefscriptcoinsperbyte branch 3 times, most recently from 51c622b to 1e110df Compare February 7, 2024 10:07
@aniketd aniketd marked this pull request as ready for review February 7, 2024 10:07
@aniketd aniketd force-pushed the aniketd/minfeerefscriptcoinsperbyte branch from 1e110df to 7b49e17 Compare February 7, 2024 11:29
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one small issue in the unit test. Which works right now, but if we ever turned it into a property with some randomness in it, the test would break.

eras/conway/impl/src/Cardano/Ledger/Conway/Tx.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/minfeerefscriptcoinsperbyte branch from 7b49e17 to 7ef9b49 Compare February 7, 2024 14:57
@aniketd aniketd requested a review from lehins February 7, 2024 14:57
* Rename it to MinFeeRefScriptCostPerByte.
* Update its type from Coin to NonNegativeInterval.
@aniketd aniketd force-pushed the aniketd/minfeerefscriptcoinsperbyte branch from 7ef9b49 to 9ba9316 Compare February 7, 2024 14:58
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, there is some conflict right now. Other than that it is ready to go

@lehins lehins enabled auto-merge February 7, 2024 15:00
@lehins lehins merged commit 619c385 into master Feb 7, 2024
11 of 15 checks passed
@neilmayhew neilmayhew deleted the aniketd/minfeerefscriptcoinsperbyte branch March 8, 2024 21:07
rooooooooob added a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request Mar 28, 2024
SebastienGllmt pushed a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request May 1, 2024
* New Conway.cddl updates (cml-chain/cml-chain-wasm)

Includes:
* IntersectMBO/cardano-ledger#4003
* IntersectMBO/cardano-ledger#4178
* IntersectMBO/cardano-ledger#4055
* IntersectMBO/cardano-ledger#4117
* IntersectMBO/cardano-ledger#4040

TODO:

[ ] need to check how this affects the script data hash and test that
[ ] multi-era

* conway multi-era update + various fixes

* resolve merge conflict

* use conway costmodels for all eras (babbage costmdls found in alonzo on sancho testnet)

* IntoIter for NonemptySet<T>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the type of minFeeRefScriptCoinsPerByte
2 participants