Prefix Set encoding with tag 258 #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/switch-to-using-set-tag-in-conway
branch
2 times, most recently
from
7e99d01 to
918a9e0
Compare
lehins
force-pushed
the
lehins/switch-to-using-set-tag-in-conway
branch
2 times, most recently
from
80cfc23 to
006943a
Compare
Starting with Conway we need to prefix all places where a Set is used
lehins
force-pushed
the
lehins/switch-to-using-set-tag-in-conway
branch
from
006943a to
c757c8a
Compare
teodanciu
reviewed
Jan 24, 2024
teodanciu
approved these changes
Jan 24, 2024
Yes we do. It was a bit late for me last night to wait for the end of CI run. |
lehins
force-pushed
the
lehins/switch-to-using-set-tag-in-conway
branch
from
40ebfc3 to
89f59d2
Compare
teodanciu
reviewed
Jan 24, 2024
teodanciu
reviewed
Jan 24, 2024
I did, still looks good to me 👍 |
lehins
force-pushed
the
lehins/switch-to-using-set-tag-in-conway
branch
from
89f59d2 to
f26eab5
Compare
4 tasks
rooooooooob
added a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
Mar 28, 2024
Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era
SebastienGllmt
pushed a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
May 1, 2024
* New Conway.cddl updates (cml-chain/cml-chain-wasm) Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era * conway multi-era update + various fixes * resolve merge conflict * use conway costmodels for all eras (babbage costmdls found in alonzo on sancho testnet) * IntoIter for NonemptySet<T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting with Conway we need to prefix all places with a tag where a Set is used when encoding
Original problem was reported in IntersectMBO/cardano-cli#567
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)