Move EpochInterval to cardano-base
#4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/move-epochinterval
branch
from
17e4470
to
8d7198b
Compare
|
Quickly fixed the things that broke due to the release of |
lehins
reviewed
Feb 16, 2024
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/EncCBOR.hs
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
lucsanszky/move-epochinterval
branch
3 times, most recently
from
b97e379
to
13414a0
Compare
lehins
reviewed
Feb 20, 2024
The `cardano-slotting` package removed the numeric instances for `EpochNo` and `EpochSize` from the main library for safety reasons. See: IntersectMBO/cardano-base#456 Those instances are now provided as orphans from the `cardano-slotting` `testlib` for testing convenience. However, everywhere else the code is updated to comply with the above breaking changes.
Both `EpochInterval` and `addEpochInterval` was moved to `cardano-slotting` in `cardano-base` as part of IntersectMBO/cardano-base#456. Import them from there and re-export them via `BaseTypes`.
Lucsanszky
force-pushed
the
lucsanszky/move-epochinterval
branch
from
4c9834e
to
69de6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3944
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)