-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move EpochInterval
to cardano-base
#4087
Conversation
17e4470
to
8d7198b
Compare
Quickly fixed the things that broke due to the release of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to version bounds are needed, but otherwise looks great
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/EncCBOR.hs
Show resolved
Hide resolved
b97e379
to
13414a0
Compare
The `cardano-slotting` package removed the numeric instances for `EpochNo` and `EpochSize` from the main library for safety reasons. See: IntersectMBO/cardano-base#456 Those instances are now provided as orphans from the `cardano-slotting` `testlib` for testing convenience. However, everywhere else the code is updated to comply with the above breaking changes.
Both `EpochInterval` and `addEpochInterval` was moved to `cardano-slotting` in `cardano-base` as part of IntersectMBO/cardano-base#456. Import them from there and re-export them via `BaseTypes`.
4c9834e
to
69de6e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Daniel!
Description
Resolves #3944
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)