Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to do constraints over trees in constrained-generators #4123

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

Also fixes some minor issues around list size

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the clarity of the module Tree.hs
The examples are also clear as a bell.
Good to go, Thanks Max for such a sweet extension.

libs/constrained-generators/src/Constrained/Base.hs Outdated Show resolved Hide resolved
@UlfNorell
Copy link
Collaborator

@lehins I'm having trouble figuring out why CI failed. It says

Tests failed for test:cardano-ledger-shelley-ma-test

but I can't for the life of me find the failing test in the log.

@lehins
Copy link
Contributor

lehins commented Mar 4, 2024

@UlfNorell Here is the reason

This is the flaky test that has been haunting us for the longest time. It is caused by the older trace generation framework that was written back in times of Shelley.
Once we are done with Conway we'll invest some time into fixing it, but for now we are forced to suffer through it. So, feel free to re-run the build.

@UlfNorell
Copy link
Collaborator

I don't think I have permissions to restart tests runs. At least I can't find the button where I remember it being.

@lehins
Copy link
Contributor

lehins commented Mar 4, 2024

I don't think I have permissions to restart tests runs.

That is strange. You do have write permission to the repo, so you should be able to restart GithubActions CI (FYI, hydra CI is not required, so there is no need to restart if there are failures)

At least I can't find the button where I remember it being.

It should be right here:

image

@MaximilianAlgehed
Copy link
Collaborator Author

I have restart rights. I decided to force push here because it was faster. The time is dominated by the 8.10.7 build - so waiting for that to finish before doing a restart (you can't restart while things are running) would be slower. However, I guess the best option would have been to cancel the 8.10 job and then re-start both the failed and 8.10 job. Good to remember next time.

@MaximilianAlgehed MaximilianAlgehed merged commit 3cbce69 into master Mar 4, 2024
16 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-constrained-tree branch March 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants