-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to do constraints over trees in constrained-generators
#4123
Conversation
ea51bbd
to
039b569
Compare
ddc2d7c
to
2ba4e40
Compare
2ba4e40
to
1743481
Compare
tests with `withMaxSuccess` on the repl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the clarity of the module Tree.hs
The examples are also clear as a bell.
Good to go, Thanks Max for such a sweet extension.
@lehins I'm having trouble figuring out why CI failed. It says
but I can't for the life of me find the failing test in the log. |
@UlfNorell Here is the reason This is the flaky test that has been haunting us for the longest time. It is caused by the older trace generation framework that was written back in times of Shelley. |
I don't think I have permissions to restart tests runs. At least I can't find the button where I remember it being. |
0566b6e
to
24f3c0b
Compare
That is strange. You do have write permission to the repo, so you should be able to restart GithubActions CI (FYI, hydra CI is not required, so there is no need to restart if there are failures)
It should be right here: |
I have restart rights. I decided to force push here because it was faster. The time is dominated by the |
Description
Also fixes some minor issues around list size
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)