Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance testing for ENACT #4338

Merged
merged 1 commit into from
May 27, 2024
Merged

Add conformance testing for ENACT #4338

merged 1 commit into from
May 27, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented May 17, 2024

Description

Adds conformance testing for the ENACT rule. Because the environment of ENACT is the unit type, I had to add associated types to ExecSpecRule that enable overwriting the types that the constrained generator generates as long as there's a way to inject that type into the environment/state/signal that we need in order to run the rule. With this change we should be able to get rid of ExecContext at some point when we get to refactoring the conformance tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/misc-conformance branch 5 times, most recently from d447cd3 to 4000184 Compare May 22, 2024 09:06
@Soupstraw Soupstraw changed the title Added conformance tests for various subrules Add conformance testing for ENACT May 22, 2024
@Soupstraw Soupstraw force-pushed the jj/misc-conformance branch 2 times, most recently from 9699ca7 to 4300f12 Compare May 22, 2024 10:36
@Soupstraw Soupstraw marked this pull request as ready for review May 22, 2024 10:37
@Soupstraw Soupstraw requested review from lehins, Lucsanszky, aniketd, teodanciu and MaximilianAlgehed and removed request for Lucsanszky May 22, 2024 10:37
@Soupstraw Soupstraw force-pushed the jj/misc-conformance branch 4 times, most recently from ac75500 to d16b3f9 Compare May 22, 2024 13:43
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please try removing all of those Inject x x instances in favor of #4350 approach. I think it would be much cleaner that way. (Side note observation: it would have been nice if it was a separate commit that introduced those instances, which would allow to revert all that work much easier)

@Soupstraw Soupstraw force-pushed the jj/misc-conformance branch 3 times, most recently from 0d94171 to fa8e31a Compare May 27, 2024 13:26
@Soupstraw Soupstraw enabled auto-merge (rebase) May 27, 2024 13:47
@Soupstraw Soupstraw merged commit d02e935 into master May 27, 2024
14 of 18 checks passed
@Soupstraw Soupstraw deleted the jj/misc-conformance branch May 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants