Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance: GOVCERT #4348

Merged
merged 5 commits into from
May 23, 2024
Merged

Conformance: GOVCERT #4348

merged 5 commits into from
May 23, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented May 22, 2024

Description

Relates to #4256

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd changed the title Aniketd/conformance govcert Conformance: GOVCERT May 22, 2024
@aniketd aniketd force-pushed the aniketd/conformance-govcert branch 2 times, most recently from f1b41b6 to 9e76b71 Compare May 22, 2024 12:32
cabal.project Outdated Show resolved Hide resolved
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Some minor nitpicks, but otherwise ready to merge.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehins lehins force-pushed the aniketd/conformance-govcert branch from 4977714 to 1d5515d Compare May 22, 2024 19:21
@aniketd aniketd force-pushed the aniketd/conformance-govcert branch from 903ec1c to 51a480d Compare May 23, 2024 12:17
@aniketd aniketd merged commit e6b6d4f into master May 23, 2024
125 checks passed
@aniketd aniketd deleted the aniketd/conformance-govcert branch May 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants