Ensure GitHub CI fails when tests are skipped due to a build failure

[neilmayhew]

Description

When one of the matrix jobs for build fails, the test job is skipped and the logic in complete was not treating this as a failure. As a result, PRs were being merged that contained build failures and hadn't passed tests.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated
• When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
  versioning process.
• The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
• All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
• Code is formatted with fourmolu (use scripts/fourmolize.sh)
• Cabal files are formatted (use scripts/cabal-format.sh)
• hie.yaml has been updated (use scripts/gen-hie.sh)
• Self-reviewed the diff

[lehins]

Nice! Thank you for fixing this

[teodanciu]

Hm, I expected the PR to successfully fail, but it succeeded! Maybe it's not rebased against master?
We should probably see it it fail with the current master, then merge it once Joosep's PR that contains the fix is in.

[neilmayhew]

Hm, I expected the PR to successfully fail, but it succeeded! Maybe it's not rebased against master? We should probably see it it fail with the current master, then merge it once Joosep's PR that contains the fix is in.

@teodanciu It did fail, before and after rebasing. The message (in the "Tests completed" job) was "Tests were skipped" and the exit code was 1.

[neilmayhew]

@lehins Do you want us to wait until master is fixed, or would you like to admin-merge this?

[teodanciu]

Merged this, I reckon it's better to have this check in sooner rather than later.

[neilmayhew]

Merged this, I reckon it's better to have this check in sooner rather than later.

Thank you! I agree.