Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -rtsopts to all test suites #4373

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

neilmayhew
Copy link
Contributor

@neilmayhew neilmayhew commented May 30, 2024

  • Use heap limiting in CI to ensure we don't exceed memory quotas
  • Add diagnostic display of disk and memory space to CI

This allows using +RTS -M... if we ever want to heap-limit tests

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to keep the added -rtsopts flag. So if you could run the scripts/cabal-format.sh and remove changes to haskell.yaml we could merge this PR

@neilmayhew neilmayhew changed the title Check memory and disk limits in CI Add -rtsopts to all test suites May 30, 2024
@neilmayhew
Copy link
Contributor Author

Done. Ready for merging.

This allows using +RTS -M... if we ever want to heap-limit tests
@lehins lehins force-pushed the neilmayhew/ci-memory-limit branch from 5b7e8b5 to 77f362b Compare May 30, 2024 16:32
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you.

@neilmayhew neilmayhew enabled auto-merge May 30, 2024 19:41
@neilmayhew neilmayhew merged commit 6313cb5 into master May 30, 2024
133 of 137 checks passed
@neilmayhew neilmayhew deleted the neilmayhew/ci-memory-limit branch May 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants