Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the size of the committee for testing #4386

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Jun 5, 2024

Description

Follow up to #4376

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the ldan/test-with-bigger-committee branch 5 times, most recently from c8255eb to 454c1e7 Compare June 13, 2024 18:39
@Lucsanszky Lucsanszky marked this pull request as ready for review June 14, 2024 09:35
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only suggested some minor improvements

@Lucsanszky Lucsanszky force-pushed the ldan/test-with-bigger-committee branch 2 times, most recently from a7eda0b to a7e070a Compare June 20, 2024 15:02
@lehins lehins force-pushed the ldan/test-with-bigger-committee branch from a7e070a to de12f18 Compare June 20, 2024 20:50
@lehins lehins enabled auto-merge (squash) June 20, 2024 20:50
@Lucsanszky Lucsanszky force-pushed the ldan/test-with-bigger-committee branch from de12f18 to 402da64 Compare June 21, 2024 12:58
@lehins lehins merged commit c4fbc05 into master Jun 21, 2024
125 of 126 checks passed
@lehins lehins deleted the ldan/test-with-bigger-committee branch June 21, 2024 14:41
tdammers pushed a commit that referenced this pull request Jul 23, 2024
* Increase committee size to `2` in tests

* Add helper function for committee yes votes

* Improve HF initiation w/ `< CommitteeMinSize` test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants