Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-chain inputs validation #377

Closed
MSzalowski opened this issue Mar 4, 2024 · 5 comments · Fixed by #490
Closed

On-chain inputs validation #377

MSzalowski opened this issue Mar 4, 2024 · 5 comments · Fixed by #490
Assignees
@MSzalowski @pmbinapps
Labels
🖥 Frontend Frontend related
Milestone
Byron - GA Submit...

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Mar 4, 2024 •
edited
Loading

PART OF #376

Why

As a user, I want to be informed if the provided data is wrong.

What

Each of the inputs of Treasury Governance Action type should provide the validation.

Link to figma

How

Validate if the input values might be submitted on-chain.

Rules that should be applied to fields:

Input Name Shape
Stake (Reward) Addresses Array of Betch32 or Hex encoded stake addresses
Amount in Lovelace for each address Decimal Numbers
@m-i-k-e
Copy link

m-i-k-e commented Mar 4, 2024

There are two errors: 'hash not correct' and Missing URL

Note: the Feedback button should be coming from or pointed at UserSnap. @MSzalowski There needs to be an issue to find out how to connect UserSnap to GovTool in a way that we can make these buttons. Perhaps there is a way to tag the button in the HTML so it goes directly to UserSnap?

https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=8601%3A55827&mode=design&t=ddbBbWrFuXASbzFR-1

https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=8526%3A89666&mode=design&t=ddbBbWrFuXASbzFR-1

@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label Mar 4, 2024
MSzalowski added a commit that referenced this issue Mar 11, 2024
@MSzalowski
[#377, #380, #432] feat: form inputs validation
e035f0c
@MSzalowski MSzalowski mentioned this issue Mar 11, 2024
Merged
5 tasks
MSzalowski added a commit that referenced this issue Mar 11, 2024
@MSzalowski
[#377, #432] feat: form inputs validation
e959a76
MSzalowski added a commit that referenced this issue Mar 12, 2024
@MSzalowski
[#377, #432] feat: form inputs validation
ea47ef0
MSzalowski added a commit that referenced this issue Mar 12, 2024
@MSzalowski
[#377, #432] feat: form inputs validation
f80bc5e
MSzalowski added a commit that referenced this issue Mar 12, 2024
@MSzalowski
[#377, #432] feat: form inputs validation
2de724b
MSzalowski added a commit that referenced this issue Mar 12, 2024
@MSzalowski
Merge pull request #445 from IntersectMBO/feat/432-governance-action-…
938907c 
…provider

[#377, #432] feat: form inputs validation
@MSzalowski
Copy link
Contributor Author

Closed with #445

@MSzalowski MSzalowski self-assigned this Mar 12, 2024
@MSzalowski
Copy link
Contributor Author

@qa:
Status of current implementation:

Stake key and amount are agreed to be just strings (NOT AN ARRAYS)

@pmbinapps pmbinapps mentioned this issue Mar 12, 2024
Merged
MSzalowski added a commit that referenced this issue Mar 13, 2024
@MSzalowski
Merge pull request #459 from IntersectMBO/develop
008126e 
test: #188, #364, #365, #377, #432, #442, #446 #459
@MSzalowski MSzalowski mentioned this issue Mar 13, 2024
Merged
pmbinapps added a commit that referenced this issue Mar 13, 2024
@pmbinapps
Merge pull request #460 from IntersectMBO/test
f0f99c6 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
MSzalowski added a commit that referenced this issue Mar 15, 2024
@MSzalowski
[#377] fix: validation of ada amount
88e2a2b
@MSzalowski MSzalowski mentioned this issue Mar 15, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Mar 15, 2024 that will close this issue
[#377] fix: validation of ada amount #490
Merged
5 tasks
MSzalowski added a commit that referenced this issue Mar 15, 2024
@MSzalowski
Merge pull request #490 from IntersectMBO/fix/377/fix-validation-of-a…
59d7704 
…da-amount

[#377] fix: validation of ada amount
@pmbinapps
Copy link

OK

  • positive integer is approved
  • 0 amount
  • 1234e100

NOT OK for:

  • 100,0
  • 1000.0
  • 100.0

@pmbinapps pmbinapps self-assigned this Mar 15, 2024
@MSzalowski MSzalowski mentioned this issue Mar 15, 2024
Merged
5 tasks
MSzalowski added a commit that referenced this issue Mar 15, 2024
@MSzalowski
Merge pull request #491 from IntersectMBO/develop
209264e 
[#377] fix validation of ada amount
@MSzalowski MSzalowski mentioned this issue Mar 15, 2024
Merged
@pmbinapps
Copy link

OK NOW

100,0
1000.0
100.0

GA transaction submitted correctly:
https://jam.dev/c/c076672d-518a-4349-a59d-8f00b1ca5cab

MSzalowski pushed a commit that referenced this issue Mar 19, 2024
@pmbinapps @MSzalowski
Merge pull request #460 from IntersectMBO/test
fa67064 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

@pmbinapps pmbinapps

Labels
🖥 Frontend Frontend related
Projects
Govtool all
Status: In staging
Milestone
Byron - GA Submitter - Error handling...
Development

Successfully merging a pull request may close this issue.

[#377] fix: validation of ada amount IntersectMBO/govtool
3 participants
@m-i-k-e @MSzalowski @pmbinapps