Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform user about required for governance action deposit #382

Closed
MSzalowski opened this issue Mar 4, 2024 · 4 comments · Fixed by #389
Closed

Inform user about required for governance action deposit #382

MSzalowski opened this issue Mar 4, 2024 · 4 comments · Fixed by #389
Assignees
@MSzalowski
Labels
🖥 Frontend Frontend related
Milestone
Byron - GA Submit...

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Mar 4, 2024 •
edited
Loading

Why

As someone submitting a governance action

I want to be told in advance of submitting the transaction to my wallet that I will need to:

  • pay a deposit in order to submit a governance action
  • what the deposit cost will be
  • When my deposit will be returned
  • That the deposit will not affect my voting power

So that I am not surprised when my wallet tries to extract the deposit from me, or I am unable to submit a transaction

What

There is an info box in Figma that has the correct information in the flow

Link to figma

DoD

People who want to submit a governance action are told about the deposit.
@MSzalowski
Copy link
Contributor Author

MSzalowski commented Mar 4, 2024 •
edited
Loading

@m-i-k-e
Is the design (link in description) ready for dev?

@m-i-k-e
Copy link

m-i-k-e commented Mar 5, 2024

Yes, @MSzalowski Ready now.

https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=8601%3A56110&mode=design&t=om4NyIwTuWWwHSPZ-1

@MSzalowski MSzalowski assigned MSzalowski and unassigned m-i-k-e Mar 5, 2024
MSzalowski added a commit that referenced this issue Mar 5, 2024
@MSzalowski
[#382] add create governance action information screen
919b4b2
@MSzalowski MSzalowski mentioned this issue Mar 5, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Mar 5, 2024 that will close this issue
[#382] add create governance action information screen #389
Merged
5 tasks
@MSzalowski
Copy link
Contributor Author

On review on @Sworzen1

MSzalowski added a commit that referenced this issue Mar 5, 2024
@MSzalowski
[#382] add create governance action information screen
db357e8
MSzalowski added a commit that referenced this issue Mar 5, 2024
@MSzalowski
[#382] add create governance action information screen
f6c6f0f
MSzalowski added a commit that referenced this issue Mar 5, 2024
@MSzalowski
[#382] add create governance action information screen
f9a2436
@pmbinapps pmbinapps mentioned this issue Mar 7, 2024
Merged
pmbinapps pushed a commit that referenced this issue Mar 7, 2024
@MSzalowski @pmbinapps
[#382] add create governance action information screen
b2fbda1
@pmbinapps
Copy link

OK on test-sancho.
Note: Design could miss Voting power

Image

@pmbinapps pmbinapps mentioned this issue Mar 8, 2024
Merged
@MSzalowski MSzalowski mentioned this issue Mar 13, 2024
Merged
pmbinapps added a commit that referenced this issue Mar 13, 2024
@pmbinapps
Merge pull request #460 from IntersectMBO/test
f0f99c6 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
MSzalowski pushed a commit that referenced this issue Mar 19, 2024
@pmbinapps @MSzalowski
Merge pull request #460 from IntersectMBO/test
fa67064 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🖥 Frontend Frontend related
Projects
Govtool all
Status: In staging
Milestone
Byron - GA Submitter - Information ab...
Development

Successfully merging a pull request may close this issue.

[#382] add create governance action information screen IntersectMBO/govtool
3 participants
@m-i-k-e @MSzalowski @pmbinapps