Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Card atom #433

Merged
merged 1 commit into from
Mar 13, 2024
Merged

add Card atom #433

merged 1 commit into from
Mar 13, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Mar 8, 2024 •
edited
Loading

List of changes

  • Add Card atom
  • add colors from design system
  • customize mui theme (Chip and shadow)

Checklist

  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

MSzalowski
MSzalowski requested changes Mar 8, 2024
View reviewed changes
govtool/frontend/src/theme.ts Outdated Show resolved Hide resolved
govtool/frontend/src/theme.ts Outdated Show resolved Hide resolved
@jdyczka jdyczka added the 🖥 Frontend Frontend related label Mar 8, 2024
Sworzen1
Sworzen1 reviewed Mar 10, 2024
View reviewed changes
govtool/frontend/src/colors.ts Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/Card.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/components/atoms/index.ts Outdated Show resolved Hide resolved
govtool/frontend/src/theme.ts
theme.shadows[2] = "0px 1px 2px 0px rgba(0, 51, 173, 0.08), 0px 2px 10px 2px rgba(0, 51, 173, 0.15)";
theme.shadows[3] = "0px 1px 3px 0px rgba(0, 51, 173, 0.08), 0px 4px 12px 3px rgba(0, 51, 173, 0.15)";
theme.shadows[4] = "0px 2px 3px 0px rgba(0, 51, 173, 0.08), 0px 6px 14px 4px rgba(0, 51, 173, 0.15)";
theme.shadows[5] = "0px 4px 4px 0px rgba(0, 51, 173, 0.08), 0px 8px 20px 6px rgba(0, 51, 173, 0.15)";
Copy link
Contributor

@Sworzen1 Sworzen1 Mar 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty line on end

@jdyczka jdyczka requested a review from MSzalowski March 13, 2024 09:49
@jdyczka jdyczka merged commit d5f0813 into develop Mar 13, 2024
1 check passed
@jdyczka jdyczka deleted the card-atom branch March 13, 2024 10:09
@MSzalowski MSzalowski mentioned this pull request Mar 13, 2024
Merged
pmbinapps added a commit that referenced this pull request Mar 13, 2024
@pmbinapps
Merge pull request #460 from IntersectMBO/test
f0f99c6 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
MSzalowski pushed a commit that referenced this pull request Mar 19, 2024
@pmbinapps @MSzalowski
Merge pull request #460 from IntersectMBO/test
fa67064 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdyczka @MSzalowski @Sworzen1 @j-dyczka