Homogenize Shelley versions in Cardano NTC versions #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
amesgen
force-pushed
the
amesgen/homogenous-cardano-n2c-versions
branch
from
6c2af64
to
a0632f9
Compare
carbolymer
approved these changes
Jan 8, 2024
nfrisby
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Approving. This complies with our latest plan for versioning queries: #864 (comment)
Minor: we chatted and decided QueryVersioning.md should mention that---at least in this specific case---eras before Conway can still answer Conway-specific eras, since those queries' types happen to admit the degeneration values (eg mempty).
amesgen
force-pushed
the
amesgen/homogenous-cardano-n2c-versions
branch
from
a0632f9
to
30d6f1f
Compare
|
I like this changes :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #862
Note that
CardanoNodeToClientVersion12is experimental, so this change does not impact backwards-compatibility.