Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review need for MonadRandom #1460

Closed
edsko opened this issue Jan 14, 2020 · 1 comment
Closed

Review need for MonadRandom #1460

edsko opened this issue Jan 14, 2020 · 1 comment
Labels
consensus issues related to ouroboros-consensus technical debt

Comments

@edsko
Copy link
Contributor

edsko commented Jan 14, 2020 •
edited
Loading

The generic crypto classes

All have MonadRandom constraints. We should re-evaluate whether or not this is really required, and if so, document why. Currently this constraint trickles through to consensus for block production, both for the leadership check and for block production itself, and it's not at all clear why those functions should require access to system random data; after all, entropy should come from the blockchain itself.
@edsko edsko added priority medium consensus issues related to ouroboros-consensus byron Required for a Byron mainnet: replace the old core nodes with cardano-node labels Jan 14, 2020
This was referenced Apr 28, 2020
Merged
Closed
@mrBliss mrBliss removed the byron Required for a Byron mainnet: replace the old core nodes with cardano-node label Jun 3, 2020
@edsko
Copy link
Contributor Author

edsko commented Jul 7, 2020

Closed in favour of #2036.

@edsko edsko closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrBliss @edsko