Merge pull request #1255 from Intervention/bugfix/maximum-path-length

Fix bug with very long file/path names
Intervention · Jan 14, 2024 · 9531e0e · 9531e0e
2 parents aafc9b6 + c990371
commit 9531e0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/Drivers/Gd/Decoders/FilePathImageDecoder.php b/src/Drivers/Gd/Decoders/FilePathImageDecoder.php
@@ -12,12 +12,16 @@ class FilePathImageDecoder extends BinaryImageDecoder implements DecoderInterfac
 {
     public function decode(mixed $input): ImageInterface|ColorInterface
     {
-        if (! is_string($input)) {
+        if (!is_string($input)) {
+            throw new DecoderException('Unable to decode input');
+        }
+
+        if (strlen($input) > PHP_MAXPATHLEN) {
             throw new DecoderException('Unable to decode input');
         }
 
         try {
-            if (! @is_file($input)) {
+            if (!@is_file($input)) {
                 throw new DecoderException('Unable to decode input');
             }
         } catch (Exception) {

diff --git a/src/Drivers/Imagick/Decoders/FilePathImageDecoder.php b/src/Drivers/Imagick/Decoders/FilePathImageDecoder.php
@@ -16,6 +16,10 @@ public function decode(mixed $input): ImageInterface|ColorInterface
             throw new DecoderException('Unable to decode input');
         }
 
+        if (strlen($input) > PHP_MAXPATHLEN) {
+            throw new DecoderException('Unable to decode input');
+        }
+
         try {
             if (!@is_file($input)) {
                 throw new DecoderException('Unable to decode input');
@@ -25,7 +29,7 @@ public function decode(mixed $input): ImageInterface|ColorInterface
         }
 
         // decode image
-        $image =  parent::decode(file_get_contents($input));
+        $image = parent::decode(file_get_contents($input));
 
         // set file path on origin
         $image->origin()->setFilePath($input);