-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implemented text outline #1296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for the pull request. I have tested the feature and it works fine. However, I have three important things that need to be added before I can integrate it.
-
The font system has been heavily rewritten by me in Implement text wrapping #1292. I suggest that you build your PR on the state of the not-yet-integrated state of #1292 , which will be integrated in the next minor release on February 17, 2024.
-
Intervention image is a library that provides a unified API for GD and Imagick. The goal is that every command will produce the same result when you replace the driver. I realize that this is not always 100% possible, as GD and Imagick work differently, but it should be a benchmark. However, the new feature currently only works with GD. I would ask you to add it for Imagick as well.
-
Some minor comments I wrote directly in the code.
Thank you for your updates. Please edit the following two things because otherwise I cannot merge it.
Text outline with Imagick is definitely possible. $draw = new ImagickDraw();
$draw->setStrokeColor('#000');
$draw->setStrokeWidth(4);
$draw->setStrokeAntialias(true); https://www.php.net/manual/en/imagickdraw.setstrokecolor.php And it's even easier than with GD. 😄 |
merged feature/text-wrapping into add-outline-to-text branch |
I am lost with the failed checks |
if ($ox !== 0 || $oy !== 0) { // Skip drawing outline for the main text | ||
imagettftext( | ||
$frame->native(), | ||
$this->adjustedFontSize(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not exist anymore.
} | ||
|
||
$draw = new ImagickDraw(); | ||
$draw->setStrokeColor($font->strokeColor()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work that way. Please check types.
|
||
$draw = new ImagickDraw(); | ||
$draw->setStrokeColor($font->strokeColor()); | ||
$draw->setStrokeWidth($font->strokeWidth()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work that way. Please check types.
Please Sir I'd love to improve on my open source contribution what are the
things you feel I could improve and what other open source task can I take
on
Gideon Amowogbaje
[image: https://]about.me/amowogbaje
<https://about.me/amowogbaje?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=edit_panel&utm_content=plaintext>
…On Mon, Feb 12, 2024 at 3:11 PM Oliver Vogel ***@***.***> wrote:
Closed #1296 <#1296>.
—
Reply to this email directly, view it on GitHub
<#1296 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACC5L4VLF3FILQZMO5D552LYTIPKRAVCNFSM6AAAAABC3UN6K6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43TKMBZGYZTGOI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I just closed this because you opened another MR with the same content. Lets work on #1300 |
I noticed the stroke functionality on text watermark was not functional so I implemented that kindly merge please so i can see it in the next installment