Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic bugs in ark_poly Add and Sub impls #43

Open
teor2345 opened this issue Apr 15, 2024 · 1 comment
Open

Fix panic bugs in ark_poly Add and Sub impls #43

teor2345 opened this issue Apr 15, 2024 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@teor2345
Copy link
Collaborator

teor2345 commented Apr 15, 2024

Some missing truncate_leading_zeroes() in ark_poly operator impls can cause a panic in degree():

We can submit a PR to ark_poly, get it merged, and then upgrade to the next release.

In the meantime, we can add a truncate_to_canonical_form() in our own Poly impls. This means we can't use derive_more macros, unless the underlying implementation is correct.

@teor2345 teor2345 added bug Something isn't working wontfix This will not be worked on labels Apr 15, 2024
@teor2345
Copy link
Collaborator Author

teor2345 commented Apr 15, 2024

Currently this is fixed by depending on arkworks-rs/algebra#638 via arkworks-rs/algebra@8233e9a in PR #32.

We don't use SparsePolynomial, so this bug shouldn't happen to us.

@teor2345 teor2345 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant