It stopped to work

[Leksat]

Got error message today:

In PackageDiff.php line 135:

  Could not open file ad66625dce6fd04da4b628f870a7230cce53fd10:apps/silverbac  
  k-drupal/composer.lock or find it in git as ad66625dce6fd04da4b628f870a7230  
  cce53fd10:apps/silverback-drupal/composer.lock 

I tried to debug it by adding a new job step:

git show ad66625dce6fd04da4b628f870a7230cce53fd10:apps/silverback-drupal/composer.lock

This one worked without any issues.

Debugging here: AmazeeLabs/silverback-mono#1021

[Leksat]

Hmm, when I run the same code as in \IonBazan\ComposerDiff\PackageDiff::getFileContents, it works just fine.

Could it be that the action needs some kind of a GitHub permission to read from the git history?

[adam-delaney]

I am experiencing the same issue. I've checked the workflow permissions on the repo I'm running the action on and it appears to have read permission to the repo.

[IonBazan]

Thanks for the reporting! I will have a closer look at this after Easter.
My first guess would be that it's related to actions/checkout v3 - I am still using v2 in my projects and it worked last time. @Leksat can you help to check if reverting to v2 helps?

[weitzman]

Affecting me too. I'm pinned to actions/checkout@v2 and it isn't helping. Debug run at https://github.com/massgov/openmass/runs/6047519645?check_suite_focus=true

[Leksat]

Confirming. Downgrading actions/checkout tov2 does not help.

[oradwell]

we're also having this issue :/ on actions/checkout v2

[Leksat]

@IonBazan could you add git show output and exit code to the exception here?

It could give us some hint.

[IonBazan]

@Leksat @oradwell I found that it's caused by actions/checkout#760 - I will be fixing it now here.

[IonBazan]

The issue should be now fixed. Please help to verify, @Leksat @oradwell @adam-delaney @weitzman. Here is one of successful runs after the fix: IonBazan/composer-diff-example#1

I have also released v1.6.1 of Composer-Diff which improves git command logging and fixes some minor compatibility problems.

Please note that it only works for repositories referenced in $GITHUB_WORKSPACE - any other repo would require adding git config --global --add safe.directory <path> to the workflow but at least the error will show some more details on how to fix this problem from now.

[Leksat]

The error is gone 🎉 Thank you!

Now there is a new little issue. When there are no composer changes, the action output is not empty, but is set to the following:
::set-output name=composer_diff_exit_code::0

[IonBazan]

I believe f4eb9f4 should fix that - please try to use IonBazan/composer-diff-action@master to see if that works.

[Leksat]

@IonBazan it works like a charm on master branch 🎉

[IonBazan]

@Leksat great! Closing this issue then 🚀

[oradwell]

thanks both. I can confirm it works flawlessly