Search for libsystemd instead of libsystemd-journal #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this looks ok overall, have you tried this on an older system with an older version of systemd? I'm more concerned about systems that want to upgrade irqbalance, but keep other things like systemd at an older level. |
|
It will indeed not work with the older versions of systemd. I'll see if I can add the detection of the older library as a fallback |
|
Thanks. I would be much more comfortable merging it if you can add that please. -PJ |
libsystemd-journal has been merged in libsystemd at version 209 (2014-02-20), make the configure search for that "new" library first and then fallback to the old one. Closes: Irqbalance#33
|
OK, I've update my commit and force pushed it |
|
Looks good, thanks Laurent! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsystemd-journal has been merged in libsystemd at version 209
(2014-02-20), make the configure search for that "new" library.
Closes: #33