Expansion of policy scripting #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its been deprecated for a few years and releases now, its time to reap this option Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Latest gcc caught some errors in our string copying routines. Fix those up Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
The policyscript directive allows for the specifcaion of a single script to define policy for all hardware on a system, which is good as a site/host specific utility, but it makes for difficult work in the event that vendors wish to provide guidance for only their own hardware (i.e. if vendor A wants certain hardware to follow affinity_hinting without affecting other hardware). To manage this, lets enhance policyscript to allow the specification of an entire directory, to which multiple scripts can be added. Semantics for this new directory feature are the same as for the single script case, except that the script exit codes have additional meaning: exit code 0 - the script indicates that the referenced irq relates to a device that this script recognizes and further script processing should stop exit code 1 - the script indicates that the referenced irq does not relate to a device the script recognizes, and script processing should continue exit code >2 - the script indicates an error has occured, and any output from it should be ignored, script processing should continue Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enhances our policy script feature. Currently irqbalance has the ability to use a single policy script, which must contain the logic to properly handle/ignore all devices, which is less than ideal. This feature enhances policyscripting to allow for a directory to be specified that holds multiple scripts, that can control individual devices. The idea being that if a IHV creates a device that needs special irqbalance policy, they can submit a script for inclusion that detects only their device and handles it accordingly.