Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] All PRs are showing as failing testing. #885

Closed
rosiel opened this issue Jul 19, 2022 · 1 comment
Closed

[BUG] All PRs are showing as failing testing. #885

rosiel opened this issue Jul 19, 2022 · 1 comment

Comments

@rosiel
Copy link
Member

rosiel commented Jul 19, 2022

All PRs on Drupal 10 fail because Islandora requires Context, and Context doesn't yet work with D10. I think we should remove the D10 testing.

What steps does it take to reproduce the issue?

  • When does this issue occur?
    Every pull request

  • Which page does it occur on?
    https://github.com/Islandora/islandora/pulls

  • What happens?
    Shows "X" beside each PR

  • What did you expect to happen?
    Those tests are already marked as "allow fail" but in Github that means the testing will not be halted and all other tests will attempt. Github doesn't let us have a nicer icon when the "allow fail" tests fail.

Which version of Islandora are you using?
dev

Any related open or closed issues to this bug report?

no

@rosiel
Copy link
Member Author

rosiel commented Aug 2, 2022

Closing. It is still showing red for open PRs because upstream changes to the build file don't seem to be catching on.

@rosiel rosiel closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant