Skip to content

Commit

Permalink
remove coding standards ignore
Browse files Browse the repository at this point in the history
  • Loading branch information
ruebot committed Dec 13, 2013
1 parent 8a3ce46 commit 38ed4ea
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 22 deletions.
4 changes: 1 addition & 3 deletions includes/ingest.batch.inc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ define('ISLANDORA_BATCH_EMPTY_SET', 2);

/**
* Function to get the average.
*
*
* @param array $context
* The context
*/
Expand Down Expand Up @@ -154,11 +154,9 @@ function islandora_batch_ingest_process(array $parameters, &$context) {
*/
function islandora_batch_restrict_to_set($query, $table_alias, $ingest_set) {
if ($ingest_set) {
// @codingStandardsIgnoreStart
$query->condition("$table_alias.id", array_map(function ($o) {return $o->id;
}
, $ingest_set));
// @codingStandardsIgnoreEnd
}
}

Expand Down
13 changes: 4 additions & 9 deletions includes/islandora_batch_object_base.inc
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,15 @@
* Abstract base class for objects ingested via batch framework.
*/

// @codingStandardsIgnoreStart
// This Whole file is ignored due to classes and methods are not camelcase and it
// being called all over the place. All of the other coding standards are met.

/**
* Batch interface.
*
* Implementing classes should subclass some version of FedoraObject, so
* Implementing classes should subclass some version of FedoraObject, so
*/
abstract class IslandoraBatchObject extends IslandoraNewFedoraObject {
/**
* The initial batch state.
*
*
* @return int
* Used to determine the initial state of the object in the queue.
* - 0: Not ready to be processed.
Expand All @@ -43,7 +39,7 @@ abstract class IslandoraBatchObject extends IslandoraNewFedoraObject {
/**
* Get the resources to which we should link in the database.
*
* Should be in the format used by
* Should be in the format used by
* IslandoraBatchPreprocessor::add_to_database().
*/
abstract public function get_resources();
Expand All @@ -57,7 +53,7 @@ abstract class IslandoraBatchObject extends IslandoraNewFedoraObject {
* Should only be used during preprocessing.
*
* @return array
* An array of IslandoraBatchObjects, which will be put into the database
* An array of IslandoraBatchObjects, which will be put into the database
*/
public function get_children(IslandoraTuque $connection) {
return array();
Expand All @@ -70,4 +66,3 @@ abstract class IslandoraBatchObject extends IslandoraNewFedoraObject {
*/
abstract public function add_relationships();
}
// @codingStandardsIgnoreEnd
5 changes: 0 additions & 5 deletions includes/islandora_scan_batch.inc
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
* or the old D6 zip batch ingester.
*/

// @codingStandardsIgnoreStart
// This Whole file is ignored due to classes and methods are not camelcase and it
// being called all over the place. All of the other coding standards are met.

/**
* A class which is capable of getting the listing of a directory or zip file.
*
Expand Down Expand Up @@ -515,4 +511,3 @@ EOXML;
$this->models = $this->preprocessor_parameters['content_models'];
}
}
// @codingStandardsIgnoreEnd
6 changes: 1 addition & 5 deletions includes/preprocessor_base.inc
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
* Abstract preprocessor base class for batch.
*/

// @codingStandardsIgnoreStart
// This Whole file is ignored due to classes and methods are not camelcase and it
// being called all over the place. All of the other coding standards are met.
/**
* Lock exception.
*/
Expand Down Expand Up @@ -88,7 +85,7 @@ abstract class IslandoraBatchPreprocessor {
* @param array $resources
* An associative array of arrays, mapping types of resources to an array
* of relevant resources for the given object.
*
*
* @return string
* The PID of the object (one will be allocated if the object does not
* already have one; otherwise, that on the object will be returned).
Expand Down Expand Up @@ -120,4 +117,3 @@ abstract class IslandoraBatchPreprocessor {
return $object->id;
}
}
// @codingStandardsIgnoreEnd

0 comments on commit 38ed4ea

Please sign in to comment.