Skip to content

Commit

Permalink
Cleanup Vestigials
Browse files Browse the repository at this point in the history
* No arg GmMenu constructor should call super constructor.
* Add missing GmMenuBar localization tags.
* openFrame on DefaultNode was not needed.
* TODO for GMX physics friction/awake/kinematic is really just a NOTE.
* GlyphMetric did not need to be an UpdateListener.
* Compared to PathPoint, GlyphMetric is safe to simply return validate.
  • Loading branch information
RobertBColton committed Jul 27, 2020
1 parent b18f458 commit 887f4a5
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 21 deletions.
2 changes: 1 addition & 1 deletion org/lateralgm/components/GmMenu.java
Expand Up @@ -33,7 +33,7 @@ public GmMenu(String s)

public GmMenu()
{
// TODO Auto-generated constructor stub
super();
}

public JMenuItem addItem(String key)
Expand Down
4 changes: 2 additions & 2 deletions org/lateralgm/components/GmMenuBar.java
Expand Up @@ -107,7 +107,7 @@ public void updateRecentFiles()
}
}
recentMenu.addSeparator();
recentMenu.addItem("GmMenuBar.CLEARRECENT");
recentMenu.addItem("GmMenuBar.CLEARRECENT"); //$NON-NLS-1$
}

protected static final Map<Class<? extends Resource<?,?>>,Character> MNEMONICS;
Expand All @@ -126,7 +126,7 @@ public GmMenuBar()

menu.addItem("GmMenuBar.NEW"); //$NON-NLS-1$
menu.addItem("GmMenuBar.OPEN"); //$NON-NLS-1$
recentMenu = (GmMenu) menu.addMenu("GmMenuBar.RECENTFILES");
recentMenu = (GmMenu) menu.addMenu("GmMenuBar.RECENTFILES"); //$NON-NLS-1$
menu.addItem("GmMenuBar.SAVE"); //$NON-NLS-1$
menu.addItem("GmMenuBar.SAVEAS"); //$NON-NLS-1$
menu.addSeparator();
Expand Down
5 changes: 0 additions & 5 deletions org/lateralgm/components/impl/DefaultNode.java
Expand Up @@ -126,11 +126,6 @@ public boolean getAllowsChildren()
return true;
}

public void openFrame()
{
// TODO Auto-generated method stub
}

public class EventNode extends DefaultNode {
/**
* NOTE: Default UID generated, change if necessary.
Expand Down
1 change: 0 additions & 1 deletion org/lateralgm/components/impl/ResNode.java
Expand Up @@ -201,7 +201,6 @@ public Object getTransferData(DataFlavor flavor) throws UnsupportedFlavorExcepti
return this;
}

@Override
public void openFrame()
{
openFrame(false);
Expand Down
3 changes: 2 additions & 1 deletion org/lateralgm/file/GMXFileReader.java
Expand Up @@ -1164,7 +1164,8 @@ public boolean invoke()
obj.put(
PGmObject.PHYSICS_DAMPING_ANGULAR,
Double.parseDouble(objdoc.getElementsByTagName("PhysicsObjectAngularDamping").item(0).getTextContent())); //$NON-NLS-1$
// TODO: Some versions of the format did not have all of the physics properties.
// NOTE: Some versions of the format did not have all of the physics properties.
// It is the same for GMK 820/821 as well.
Node fNode = objdoc.getElementsByTagName("PhysicsObjectFriction").item(0); //$NON-NLS-1$
if (fNode != null)
{
Expand Down
2 changes: 1 addition & 1 deletion org/lateralgm/main/LGM.java
Expand Up @@ -133,7 +133,7 @@

public final class LGM
{
public static final String version = "1.8.175"; //$NON-NLS-1$
public static final String version = "1.8.176"; //$NON-NLS-1$

// TODO: This list holds the class loader for any loaded plugins which should be
// cleaned up and closed when the application closes.
Expand Down
11 changes: 1 addition & 10 deletions org/lateralgm/resources/sub/GlyphMetric.java
Expand Up @@ -25,12 +25,10 @@

import java.util.EnumMap;

import org.lateralgm.main.UpdateSource.UpdateEvent;
import org.lateralgm.main.UpdateSource.UpdateListener;
import org.lateralgm.util.PropertyMap;
import org.lateralgm.util.PropertyMap.PropertyValidator;

public class GlyphMetric implements UpdateListener,PropertyValidator<GlyphMetric.PGlyphMetric>
public class GlyphMetric implements PropertyValidator<GlyphMetric.PGlyphMetric>
{
public enum PGlyphMetric
{
Expand All @@ -48,15 +46,8 @@ public GlyphMetric()
properties = new PropertyMap<PGlyphMetric>(PGlyphMetric.class,this,DEFS);
}

public void updated(UpdateEvent e)
{
// TODO Auto-generated method stub

}

public Object validate(PGlyphMetric k, Object v)
{
// TODO Auto-generated method stub
return v;
}
}

0 comments on commit 887f4a5

Please sign in to comment.