#432

[jijojosephk]

I've implemented the fix. Try to merge the PR.

[simonvanderveldt]

Fixes #432

[IsmaelMartinez]

Left a few comments mainly on function sizes. Nothing serious but I found writing smaller functions makes it easier to maintain. Main complainer is code beat https://codebeat.co/projects/github-com-ismaelmartinez-teams-for-linux-develop/pull_requests/476509 that keeps emailing me every build ! Thanks a lot for that great job

[IsmaelMartinez]

Last, but not least, can you increase the https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/package.json#L3 version number? just increase it to 1.0.8 (mainly to avoid getting close to have the same 1.3.x version as MS).

Once that build is ready, I would release it as a pre-release version so people can check the build ones.

Thanks a lot for your hard work!

[jijojosephk]

Last, but not least, can you increase the https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/package.json#L3 version number? just increase it to 1.0.8 (mainly to avoid getting close to have the same 1.3.x version as MS).

Once that build is ready, I would release it as a pre-release version so people can check the build ones.

Thanks a lot for your hard work!

@IsmaelMartinez , I've updated the version.

[IsmaelMartinez]

I have merged it but somehow the gitactions aren't publishing to GitHub anymore. I will see if I can have a look next week. Looks like it is something started failing for the previous version.

…

On Fri, 25 Jun 2021, 17:06 Jijo Joseph, ***@***.***> wrote: Last, but not least, can you increase the https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/package.json#L3 version number? just increase it to 1.0.8 (mainly to avoid getting close to have the same 1.3.x version as MS). Once that build is ready, I would release it as a pre-release version so people can check the build ones. Thanks a lot for your hard work! @IsmaelMartinez <https://github.com/IsmaelMartinez> , I've updated the version. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJHEBQEYCFK7FUGY5XBHDTUSSRTANCNFSM465AUQCQ> .