Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crash #28

Closed
Ismoh opened this issue Mar 11, 2022 · 8 comments
Closed

Game crash #28

Ismoh opened this issue Mar 11, 2022 · 8 comments
Assignees
Labels
bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop. help_wanted Extra attention is needed

Comments

@Ismoh
Copy link
Owner

Ismoh commented Mar 11, 2022

When there are too many explosions the game crashes.

I think this is due tosyncing too many velocity components

Or

because of broken de-/serialisation. First fix #27 then double check this!

@Ismoh Ismoh added bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop. help_wanted Extra attention is needed labels Mar 11, 2022
@shebpamm
Copy link

Seems to happen with simple entities too, such as a single spark bolt after some time.

Exit code is 0xc0000005 which means STATUS_ACCESS_VIOLATION so we are writing to an inaccessible memory location

@Ismoh
Copy link
Owner Author

Ismoh commented Apr 10, 2022

Nice to know! Thanks for having a look, I really appreciate it!

Where did you find the exit code and related error/exit message?

Logger.txt was empty in my case, although the logger mod was working fine til the crash.

Which branch did you use?

@shebpamm
Copy link

Further investigation shows this is probably unrelated to explosions and I'm guessing explosions crash due to syncing all the explosion particles

I could open a new issue about this, what do you think?

@Ismoh
Copy link
Owner Author

Ismoh commented Apr 10, 2022

Yea sure, go for it!

I already created a branch for #27 which might be related to this, but doesnt hurt to create a new issue for this, feel free!

One nice to have would be, when you link those tickets to have a better overview, thanks :)

@shebpamm
Copy link

Seems like explosions work after I added a filter to EntityManager that skips all entities with the filename containing "particle". Crashes experienced in #37 also mostly disappeared but I did crash once under the same conditions but was unable to reproduce that.

@shebpamm
Copy link

This was with develop branch. I'll probably make a new branch for improving the filtering and we can try to merge that to the NetworkComponents rework then.

@Ismoh
Copy link
Owner Author

Ismoh commented Apr 15, 2022

I am happy to hear this! Thanks for having a look.
I am interested in the logs, when the game crashed to see if there are lua errors. Can you provide filtered logs on errors in addition to the whole log? Somethink like "grep error". Not sure atm if there similiar stuff on windows. I used grep on debian a lot.
Yea, feel free to create a new branch! I am excited and happy to see you having fun working on NoitaMP!
If there is anything, I can help, let me know!

@Ismoh
Copy link
Owner Author

Ismoh commented Apr 15, 2022

For less confusing and mainting I am going to close this issue. Let's keep discussing about this in #37 and in #37 you can create the branch.
This issue is old and #37 is better documentated and you did a really good research there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. This will increase PATCH version number, when merged into develop. enhancement New feature or request. This will increase MINOR version number, when merged into develop. help_wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

2 participants