Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-67203 Lock down dependencies with npm-shrinkwrap #468

Closed
wants to merge 9 commits into from
Closed

LPS-67203 Lock down dependencies with npm-shrinkwrap #468

wants to merge 9 commits into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented Aug 26, 2016 •
edited
Loading

Hey @Ithildir,

I'm sending this to you because I think there's room for build improvement and because it's the first one where we define the metal-cli dependency in the package.json file.

Things that we could do to improve this:

Thanks!

@jbalsas jbalsas mentioned this pull request Aug 26, 2016
Closed
@jbalsas jbalsas changed the title LPS-62703 Lock down dependencies with npm-shrinkwrap LPS-67203 Lock down dependencies with npm-shrinkwrap Aug 26, 2016
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 2 hours 25 minutes 46 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 27d8ddb9d04ac13e3d744e57886ec236686f87a6

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    82 Jobs Passed.
    8 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/18
    Build was aborted
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-oracle12-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #32974
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:237: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:594: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:48: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:56: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:8489: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:2967: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3063: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:3481: No server is available at http://localhost:8080/web/guest
      [get] Getting: http://test-1-14/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/32974//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160826023731117.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160826023731117.txt
     [exec] 26-Aug-2016 09:37:31.318 INFO [main] org.apache.catalina.core.StandardServer.await A valid shutdown command was received via the shutdown port. Stopping the Server instance.
     [exec] 26-Aug-2016 09:37:31.318 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["http-nio-8080"]
     [exec] 26-Aug-2016 09:37:31.369 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["ajp-nio-8009"]
     [exec] 26-Aug-2016 09:37:31.420 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service Catalina
     [exec] 26-Aug-2016 09:37:31.421 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["http-nio-8080"]
     [exec] 26-Aug-2016 09:37:31.422 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["ajp-nio-8009"]
     [exec] 26-Aug-2016 09:37:31.423 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["http-nio-8080"]
     [exec] 26-Aug-2016 09:37:31.423 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["ajp-nio-8009"]
  4. test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8
    Build was aborted
  5. test-portal-acceptance-pullrequest-batch(master)/integration-oracle12-jdk8
    Build was aborted
  6. ...
For upstream results, click here.

@Ithildir
Copy link
Owner

Sent to brianchandotcom#42698.

@Ithildir Ithildir closed this Aug 26, 2016
@jbalsas jbalsas deleted the pr-578 branch April 3, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbalsas @liferay-continuous-integration @Ithildir