Support building with the upcoming Libav 10 release #2293
Conversation
All relevant distros now ship the equivalent of Libav 0.8 or newer, so drop support for everything older as it is a maintenance burden.
It is now exported by libavformat through a public API, so there is no reason to carry an outdated custom copy.
r_frame_rate is a guessed number defined as "the least common multiple of all framerates in the stream". It has been deprecated and removed in new Libav releases. Use avg_frame_rate instead, which is the average framerate of the stream.
avcodec_encode_video() has been deprecated and removed in newer libavcodec versions.
|
@asmorkalov, could you please have a look? |
|
@elenril, there are several build issues, could you please fix them: http://pullrequest.opencv.org? |
|
Seems the failing machine has a very old ffmpeg version. I cannot find exactly which one from the build logs, but if it's complaining about missing AVIO_FLAG_WRITE, then it predates even Libav 0.7 (i.e. over 3 years old). Of course I could drop the first patch and restructure the whole set to keep compatibility even with such old versions, but the ifdef hell would be getting very very messy. So I think it'd be better if you updated ffmpeg or libav on that build machine instead. |
|
@elenril The minimal supported FFmpeg version is 0.7.1. Mac builder uses 0.7.13: |
|
@elenril any updates? |
|
@elenril Thanks for PR! Are you going to fix this? |
|
@elenril I'm going to close this PR if you don't work on this. But it's would be very pity. |
|
Hi, sorry for the delay. I'd still ask you to reconsider this however. This version is over 3 years old and completely unsupported by either project. I really do not think anyone should be using them now. |
|
@elenril Thanks for your effort! @asmorkalov, will we update the Libav or the PR can be closed? |
|
@elenril, thanks for the patch! As I see, you've done a good job on cleaning up the wrappers. That being said, I have to close this PR and wait while a new one will be created that passes all our buildbot tests. |
|
On Ubuntu 14.10, OpenCV 3.x doesn't build due the too new libav version, incompatible with existing ffmpeg wrappers in OpenCV codebase, as I've reported here: http://code.opencv.org/issues/3986 |
|
Currently on Ubutnu 14.10 neither 2.4.10 nor 3.x build with ffmpeg and vtk, since apparently vtk6-dev depends on libavXXX-dev files. In general, the way I would approach this would be a new cmake drop-down-list-style option, that would enable the user to switch between libav and ffmpeg, which in turn would influence another preprocessor flag that would switch between libav & ffmpeg versions of the code, hence I think the fix proposed here is incomplete. I would not advise to sticking to just one or the other: Ubuntu will default to ffmpeg instead of libav starting from 15.04, so far as I know. I am unaware of any way libav and ffmpeg could peacefully coexist and still be useful on the same system. |
No description provided.