Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - C-model post-processing #288

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented May 13, 2024

Description

This is an hotfix for the C-model post-processing (more in general for all grouped bars plots).

It fixes issue #287 that is generated by only newer python versions.

Type of change

Please select what type of change this is.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Testing

Post-processing of C-Model now runs correctly.

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation -> not needed
  • [ x] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works -> not needed
  • [ x] General testing
    • [ x] New and existing unit tests pass locally with my changes
    • [ x] Coverage is >80%

@dodu94 dodu94 added the bug Something isn't working label May 13, 2024
@dodu94 dodu94 linked an issue May 13, 2024 that may be closed by this pull request
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide. Should we also implement this check to ensure we are using numpy arrays in the compare method?

JADE/jade/output.py

Lines 457 to 458 in 2ceffff

values = vals_df[column].values
error = err_df[column].values

@dodu94
Copy link
Member Author

dodu94 commented May 13, 2024

mmm I never saw issues there but a check more can't be bad I guess

@dodu94 dodu94 mentioned this pull request May 23, 2024
16 tasks
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide

@alexvalentine94 alexvalentine94 merged commit 6034ba9 into master Jun 5, 2024
8 checks passed
@dodu94 dodu94 deleted the fix-C-model-issue branch June 5, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Single post-processing of C-Model is bugged
2 participants