Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix - tud fng issue #290

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Hot fix - tud fng issue #290

merged 4 commits into from
Jun 5, 2024

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented May 23, 2024

Description

This PR solves issue #289 and should be merged after PR #288 Some refactoring was also made of the extract_output() function in the meantime. Additional style modifications come from the black formatting

Fixes #289

Additional dependencies introduced.
N.A.

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Testing

Both CI testing and manual testing have been performed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation -> N.A.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@dodu94 dodu94 added the bug Something isn't working label May 23, 2024
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide, tested fix and appears as working. Changes to expoutput neater, likely other places we can do similar.

@alexvalentine94 alexvalentine94 merged commit 9aa3e78 into master Jun 5, 2024
8 checks passed
@dodu94 dodu94 deleted the fix-tud-FNG-issue branch June 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Error in the post-processing of TUD-FNG
2 participants