Adjust static calls in multiple rules

This commit removes the redundant artifact upload step from the GitHub Actions workflow as it was unnecessary for the process. Also, the self::compare() calls have been replaced with static::compare() in AbstractAggregateRuleCombo, AbstractCellRuleCombo, and the pattern for BIC number verification in IsBic rule has been updated for better matching. Changes also include commenting on the NOSONAR issue where applicable.

.github/workflows/main.yml

@@ -78,13 +78,6 @@ jobs:
       - name: 👍 Code Quality
         run: make codestyle --no-print-directory
 
-      - name: Upload Artifacts
-        uses: actions/upload-artifact@v4
-        continue-on-error: true
-        with:
-          name: Tests - Current
-          path: build/
-
 
   test-lowest-versions:
     name: Tests - Lowest
@@ -117,13 +110,6 @@ jobs:
       - name: 👍 Code Quality
         run: make codestyle --no-print-directory
 
-      - name: Upload Artifacts
-        uses: actions/upload-artifact@v4
-        continue-on-error: true
-        with:
-          name: Tests - Lowest
-          path: build/
-
 
   test-latest-libs:
     name: Tests - Latest
@@ -156,13 +142,6 @@ jobs:
       - name: 👍 Code Quality
         run: make codestyle --no-print-directory
 
-      - name: Upload Artifacts
-        uses: actions/upload-artifact@v4
-        continue-on-error: true
-        with:
-          name: Tests - Latest
-          path: build/
-
 
   verify-php-binary:
     name: Verify PHP binary

src/Rules/Aggregate/AbstractAggregateRuleCombo.php

@@ -77,7 +77,7 @@ protected function validateComboAggregate(array $colValues, string $mode): ?stri
             return "<red>{$exception->getMessage()}</red>"; // TODO: Expose the error/warning message in the report?
         }
 
-        if (!self::compare($expected, $actual, $mode)) {
+        if (!static::compare($expected, $actual, $mode)) {
             return "The {$name} in the column is \"<c>{$actual}</c>\", " .
                 "which is {$verb} than the {$prefix}expected \"<green>{$expected}</green>\"";
         }

src/Rules/Cell/AbstractCellRuleCombo.php

@@ -49,7 +49,7 @@ protected function validateComboCell(string $cellValue, ?string $mode = null): ?
             return null;
         }
 
-        if (!self::compare($this->getExpected(), $this->getActual($cellValue), $mode)) {
+        if (!static::compare($this->getExpected(), $this->getActual($cellValue), $mode)) {
             return $this->getErrorMessage($cellValue, $mode);
         }
 

src/Rules/Cell/IsBic.php

@@ -38,7 +38,7 @@ public function validateRule(string $cellValue): ?string
             return null;
         }
 
-        if (\preg_match('/^[A-Za-z]{4}[A-Za-z]{2}[A-Za-z0-9]{2}([A-Za-z0-9]{3})?$/', $cellValue) === 0) {
+        if (\preg_match('/^[a-z]{4}[a-z]{2}[a-z0-9]{2}([a-z0-9]{3})?$/i', $cellValue) === 0) { // NOSONAR
             return "The value \"<c>{$cellValue}</c>\" is not a valid BIC number (ISO 9362).";
         }
 

src/Utils.php

@@ -99,7 +99,7 @@ public static function kebabToCamelCase(string $input): string
 
     public static function camelToKebabCase(string $input): string
     {
-        return \strtolower((string)\preg_replace('/(?<!^)[A-Z]/', '_$0', $input));
+        return \strtolower((string)\preg_replace('/(?<!^)[A-Z]/', '_$0', $input)); // NOSONAR
     }
 
     public static function prepareRegex(?string $pattern, string $addDelimiter = '/'): ?string