Add various new cell validation rules #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of new cell validation rules have been added to both the JSON and PHP schema files, including checks for prime numbers, Fibonacci numbers, even and odd numbers, Roman numerals, and phone numbers among others. The validation logic for these new rules has also been added.
The version of giggsey/libphonenumber-for-php-lite in composer.json has been bumped to "^8.13.33". The respective code diffs have also caused changes in composer.lock, updating references, content-hash, and dependencies' metadata.
Pull Request Test Coverage Report for Build 8457417551Details
💛 - Coveralls |
The GitHub Actions workflow has been updated to include a project installation step before updates are run. This has been implemented using make commands, ensuring that the project is correctly installed and prepared for processing update commands.
The "giggsey/locale" package has been added as a dependency in the composer.json and composer.lock files. The "giggsey/locale" package provides locale functions required by libphonenumber-for-php, which is also a project dependency.
The Github workflow tasks have been renamed for clarity and ansi color outputs have been added to the composer commands. The respect/validation and giggsey/locale dependencies were updated and a new dependency, symfony/polyfill-mbstring, was added to composer.json.
An empty string has been added to the list of valid inputs in three test cases: IsRomanTest, IsVersionTest, and PhoneTest. Additionally, a new validation has been introduced in the PhoneTest class to check for the absence of the country code, enhancing the test coverage and ensuring accurate results.
Changed the quote style of 'case' and 'default' from double quotes to single quotes for consistency with the rest of syntax in .php-cs-fixer configuration. This change will maintain consistent code readability and styling throughout the configuration file.
Added three different platforms (linux/amd64, linux/arm64/v8, and linux/386) to the Docker build step in the main GitHub workflow. This will allow the built image to be used on a wider range of systems and architectures, enhancing the overall accessibility and usability of the software.
A release trigger event has been added to the demo.yml workflow file. This ensures the specified workflow runs whenever a new release is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of new cell validation rules have been added to both the JSON and PHP schema files, including checks for prime numbers, Fibonacci numbers, even and odd numbers, Roman numerals, and phone numbers among others. The validation logic for these new rules has also been added.