Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement apply-all option for global schema application without glob patterns #150

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

SmetDenis
Copy link
Member

Renamed the apply-global command option to apply-all in CSV validation, and adjusted all related usage within the documentation, test, and action files. This change aims to improve clarity and simplicity of command usage.

The 'apply-all' option now automates the application of a single schema as global rules if no glob pattern is used. This update refines the command's functionality and improves user experience. Changes have been reflected in the documentation, test, and action files.

Renamed the `apply-global` command option to `apply-all` in CSV validation, and adjusted all related usage within the documentation, test, and action files. This change aims to improve clarity and simplicity of command usage.
The 'apply-all' option now automates the application of a single schema as global rules if no glob pattern is used. This update refines the command's functionality and improves user experience. Changes have been reflected in the documentation, test, and action files.
# Conflicts:
#	README.md
#	action.yml
#	src/Commands/ValidateCsv.php
#	tests/Commands/ValidateCsvBatchSchemaTest.php
#	tests/GithubActionsTest.php
@SmetDenis SmetDenis merged commit 1d231f6 into master Apr 7, 2024
9 of 10 checks passed
@SmetDenis SmetDenis deleted the apply-all branch April 7, 2024 13:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8589181006

Details

  • 29 of 30 (96.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 96.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Commands/ValidateCsv.php 29 30 96.67%
Totals Coverage Status
Change from base Build 8588617950: -0.009%
Covered Lines: 3151
Relevant Lines: 3257

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants