Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong distribution between new_lines #45

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Fix wrong distribution between new_lines #45

merged 1 commit into from
Jul 12, 2022

Conversation

JBenda
Copy link
Owner

@JBenda JBenda commented Jul 5, 2022

fixes #44

@JBenda JBenda added the bug Something isn't working label Jul 5, 2022
@JBenda JBenda self-assigned this Jul 5, 2022
@JBenda JBenda requested a review from brwarner July 5, 2022 06:39
@JBenda JBenda merged commit 4247ddc into JBenda:master Jul 12, 2022
@JBenda JBenda deleted the fix/NewLines#44 branch July 12, 2022 10:13
@LilithSilver LilithSilver mentioned this pull request Jul 20, 2022
Closed
@JBenda JBenda mentioned this pull request Jul 20, 2022
Merged
JBenda added a commit that referenced this pull request Jul 30, 2022
@JBenda
Fix Line distribution with function calls (#48)
de52e8a 
* add tests from #45
* Fixed new lines in functions based on #48
* no_changes should return result in an unchanged stack state
(pointed out in #48)
* but we need to save again if we encounter a second newline, in the
  case of multiple glues, and for correct visit counts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brwarner brwarner Awaiting requested review from brwarner

Assignees

@JBenda JBenda

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runner doesn't break on newlines between knots/stitches
1 participant
@JBenda