Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Line distribution with function calls #48

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Fix Line distribution with function calls #48

merged 2 commits into from
Jul 30, 2022

Conversation

JBenda
Copy link
Owner

@JBenda JBenda commented Jul 20, 2022

Function calls dont split lines correct.

Assumed problem a miss managment with no_change operations

Fix recomandet in #44 (comment) leads to wrong visit counts, since nodes visited by look aheads are not forgetten correctly

closes #45

@JBenda JBenda marked this pull request as ready for review July 25, 2022 10:05
* no_changes should return result in a unchached stack state
(pointed out in #48)

* but we need to save again if we encounter a second newline, in the
  case of multiple glues, and for correct visit counts
@JBenda JBenda merged commit de52e8a into JBenda:master Jul 30, 2022
@JBenda JBenda deleted the fix/missing_line_seperation_in_function_call branch July 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant