Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu-ci-x86_64.yaml - change spack-stack-1.7.0 location #65

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 13, 2024

Description

Change location of spack-stack install directory and split the ufs builds up by application to make it easier to see where it fails.

Note. Contains a temporary change of the soca branch - the corresponding soca PR JCSDA-internal/soca#1048 needs to be merged first if CI testing is successful, then the temporary change in CMakeLists.txt in this PR needs to be reverted. Same for https://github.com/JCSDA-internal/fv3-jedi/pull/1226

Issue(s) addressed

Resolves failing CI since rebuild of the Ubuntu CI self-hosted runner

Dependencies

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji
Copy link
Collaborator Author

@travissluka Hmmm I fixed this a few weeks ago, why is the error back?

[ 96%] Building Fortran object soca/src/soca/CMakeFiles/soca.dir/Geometry/soca_geom_mod.F90.o
ifort: command line warning #10121: overriding '-qopenmp-stubs' with '-qopenmp'
/home/ubuntu/ufs-bundle/jedi_run/ufs-bundle/soca/src/soca/Geometry/soca_geom_mod.F90(209): error #6633: The type of the actual argument differs from the type of the dummy argument.   [RESTART_CSP]
    call initialize_MOM( Start_time, Start_time, param_file, dirs, CSp, restart_CSp )
------------------------------------------------------------------------^
compilation aborted for /home/ubuntu/ufs-bundle/jedi_run/ufs-bundle/soca/src/soca/Geometry/soca_geom_mod.F90 (code 1)
make[2]: *** [soca/src/soca/CMakeFiles/soca.dir/build.make:209: soca/src/soca/CMakeFiles/soca.dir/Geometry/soca_geom_mod.F90.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 96%] Linking CXX executable test_ufo_opr_autogenerated
[ 96%] Built target test_ufo_opr_autogenerated
make[1]: *** [CMakeFiles/Makefile2:26230: soca/src/soca/CMakeFiles/soca.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 96%] Linking CXX executable test_autogeneratedfilter
[ 96%] Built target test_autogeneratedfilter
make: *** [Makefile:166: all] Error 2

@travissluka
Copy link

@climbfuji it's probably because whoever created that soca PR messed up the merge 🙄 oops. I'll push a fix

@shlyaeva "did not review at all, I trust Travis :)"

poor decision!

@travissluka
Copy link

@climbfuji I think JCSDA-internal/soca#1043 is what were you thinking of as being fixed a couple of weeks ago, but that's not the branch that works with ufs (I think after that pr gets merged, all we have left to do in develop of soca is to add logic to change where mom6 is found depending on if it is under ufs-bundle or not... getting so close to eliminating those branches!)

The soca branch this points to should build now.

I don't know if you're expecting the soca ctests to pass, but if you are:

  • vader needs to appear after gsw in this bundle, most of the tests will pass after this
  • -DMOM6SOLO=ON needs to be set when calling ExternalProject_Add(ufs-weather-model ..., however the soca ctests are not finding the mom6solo executable that gets built, and even when I manually point it to the executable those tests are failing in soca for some reason

If you are expecting the soca ctests to pass, let me know and I'll just disable the ones that aren't passing, for now. I don't want to spend too much time on this soca branch until after JCSDA-internal/soca#1043 is merged

@climbfuji
Copy link
Collaborator Author

@climbfuji I think JCSDA-internal/soca#1043 is what were you thinking of as being fixed a couple of weeks ago, but that's not the branch that works with ufs (I think after that pr gets merged, all we have left to do in develop of soca is to add logic to change where mom6 is found depending on if it is under ufs-bundle or not... getting so close to eliminating those branches!)

The soca branch this points to should build now.

I don't know if you're expecting the soca ctests to pass, but if you are:

  • vader needs to appear after gsw in this bundle, most of the tests will pass after this
  • -DMOM6SOLO=ON needs to be set when calling ExternalProject_Add(ufs-weather-model ..., however the soca ctests are not finding the mom6solo executable that gets built, and even when I manually point it to the executable those tests are failing in soca for some reason

If you are expecting the soca ctests to pass, let me know and I'll just disable the ones that aren't passing, for now. I don't want to spend too much time on this soca branch until after JCSDA-internal/soca#1043 is merged
you are right - for now, we just want the ufs to build with soca, we can worry about the tests later. CI is running here: https://github.com/JCSDA/ufs-bundle/actions/runs/9553842715

@climbfuji
Copy link
Collaborator Author

Temporarily change fv3-jedi branch to fix failing s2s tests
@climbfuji climbfuji marked this pull request as ready for review June 20, 2024 11:30
@travissluka
Copy link

@climbfuji I merged the soca PR into feature/ufs_dom_update. You can revert the branch name in the bundle here

@climbfuji climbfuji self-assigned this Jun 21, 2024
@climbfuji climbfuji added INFRA JEDI Infrastructure ALGO JEDI Algorithms labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO JEDI Algorithms INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants